-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php-symfony] Allow Symfony 7 / Remove EOL PHP / Bearer Fix #18357
[php-symfony] Allow Symfony 7 / Remove EOL PHP / Bearer Fix #18357
Conversation
4a6139c
to
ceb8a5a
Compare
ceb8a5a
to
5a6695b
Compare
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12) |
thanks for the PR i notice that this PR targets 8.0.x (upcoming major release) is it correct to say that this PR contains breaking changes (without fallbacks)? |
|
Removing support for deps is not a breaking change. The user will just not get the update. |
5a6695b
to
8501267
Compare
@dkarlovi Thanks for the information. Changed the target branch back to master |
9b09695
to
2978098
Compare
Bump requirements - add Symfony 7 support - remove support php < 8.2 (EOL) - remove symfony < 6.4 support Bug Fix - add missing $security{{name}} variable when using Bearer Auth Misc - getContentType method is deprecated; use getContentTypeFormat - use match instead of switch for simple assignments - remove default depth param from json_encode call - make data provider static (phpunit)
2978098
to
fdff7dc
Compare
also tested locally and the result seems good:
|
Bug Fix
Misc
function json_encode(mixed $value, int $flags = 0, int $depth = 512): string|false {}
)PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)